Repository navigation
Conversation
Benchmark iterations are supposed to do the same work, but GC work throws a ranch into that. For changes like ruby/ruby#18960 that don't modify the GC's workload at all, it's useful to evaluate the GC time separately.
XrXr
force-pushed
the
zjit-diff-less-gc-time
branch
from
October 24, 2026 01:59
67d77a3 to
211380e
Compare
1 task
Rubies that don't count side exits by default return nil from RubyVM::ZJIT.stats(:side_exit_count) unless run with --zjit-stats.
Subtract the previous running total, not the previous iteration's delta. Take the starting total before the first iteration so boot-time side exits aren't counted against iteration 1.
side_exits_per_iteration called .size on nil for JSON recorded with a harness-gc that doesn't track side exits. Return nil instead, and still print the without-GC timings, just without side_exit_avg.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark iterations are supposed to do the same work, but GC work
throws a ranch into that. For changes like
ruby/ruby#18960 that don't modify the GC's
workload at all, it's useful to evaluate the GC time separately.