Skip to content

gh-148467: Move BufferedIOBase close to concrete implementations - #150838

Merged
cmaloney merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-move-BufferedIOBase
Nov 12, 2026
Merged

gh-148467: Move BufferedIOBase close to concrete implementations#150838
cmaloney merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-move-BufferedIOBase

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 3, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 3, 2026
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label Jun 3, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 3, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2026
Closed
@serhiy-storchaka

serhiy-storchaka commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@birkenfeld, @benjaminp, please take a look.

@read-the-docs-community

read-the-docs-community Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35853997 | 📁 Comparing 938f19b against main (494f2e3)

  🔍 Preview build  

468 files changed · + 15 added · ± 452 modified · - 1 deleted

+ Added

± Modified

- Deleted

@StanFromIreland StanFromIreland mentioned this pull request Jul 5, 2026
Closed
StanFromIreland
StanFromIreland approved these changes Jul 5, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You have to fix the conflicts, however.

cmaloney
cmaloney reviewed Jul 5, 2026
View reviewed changes
Comment thread Doc/library/io.rst Outdated
implies writing, so this mode behaves in a similar way to ``'w'``. Add a
``'+'`` to the mode to allow simultaneous reading and writing.

The :meth:`~RawIOBase.read` (when called with a positive argument),

@cmaloney cmaloney Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this lands it looks like I missed this paragraph in gh-129011, these do have retries per PEP-475

@cmaloney cmaloney Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(They retry for EINTR, they don't retry for partial read or write)

@github-actions

github-actions Bot commented Oct 11, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 11, 2026
@cmaloney cmaloney removed needs backport to 3.13 only security fixes stale Stale PR or inactive for long period of time. labels Nov 12, 2026
@cmaloney
cmaloney merged commit ecefd40 into python:main Nov 12, 2026
35 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @cmaloney for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 12, 2026
@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka and @cmaloney, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker ecefd40671f340d543c214b80744d4301d249f37 3.14

@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161917 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 12, 2026
cmaloney added a commit that referenced this pull request Nov 13, 2026
@miss-islington @serhiy-storchaka @cmaloney
[3.15] gh-148467: Move BufferedIOBase close to concrete implementatio…
64b5cfd 
…ns (GH-150838) (#161917)

gh-148467: Move BufferedIOBase close to concrete implementations (GH-150838)

This reverts commit b6c7beb.
(cherry picked from commit ecefd40)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Cody Maloney <cmaloney@theoreticalchaos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@birkenfeld birkenfeld Awaiting requested review from birkenfeld
@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees

@cmaloney cmaloney

Labels

docs Documentation in the Doc dir needs backport to 3.14 bugs and security fixes skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @cmaloney @StanFromIreland