Repository navigation
Retry failed benchmark result pushes - #488
Open
savannahostrowski wants to merge 2 commits into
Open
savannahostrowski wants to merge 2 commits into
savannahostrowski wants to merge 2 commits into
Conversation
maurycy
approved these changes
Nov 12, 2026
There was a problem hiding this comment.
Two notes, maybe as a follow-up?
- What do you think about just adding a new command to the bench runner? Say:
python -m bench_runner push_results. This seems to be in line withLine 25 in 78c5aae
- This seems to touch only
push, not touchingpull.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another cherry-pick from my fork, with a few adjustments for upstream :)
A few months back, I encountered failed result pushes when running benchmarks across multiple machines, causing jobs to fail after the benchmarks had completed.
This PR adds up to five push attempts, rebasing before each attempt and waiting briefly between retries.