Repository navigation
Avoid artifact upload collisions between benchmark jobs - #487
Open
savannahostrowski wants to merge 2 commits into
Open
savannahostrowski wants to merge 2 commits into
savannahostrowski wants to merge 2 commits into
Conversation
maurycy
approved these changes
Nov 12, 2026
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 | ||
| with: | ||
| name: benchmark | ||
| name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} |
There was a problem hiding this comment.
I'm not sure what happens here, but _benchmark is called twice:
https://github.com/python/bench_runner/blob/main/bench_runner/templates/benchmark.src.yml#L75-L87
Does it mean reusing or ovewriting? I worry it's the latter
Member
Author
There was a problem hiding this comment.
Ah yeah, good catch. _benchmark can run for both head and base when “Also benchmark the base of this commit” is selected on a benchmark run, so machine and flags alone aren’t enough. I think I can just suffix the artifact names with job.check_run_id, which is unique to each job execution, and apply the same naming to perf artifacts too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another cherry-pick as I upstream fixes from my fork :)
This PR avoids artifact upload collisions between benchmark jobs by including the machine nickname and flags in artifact names. Currently, all jobs upload under the name
benchmark, so concurrent uploads can race and fail even withoverwrite: true.