Repository navigation
Drop nam_dict's familiar forms, keeping the nicknames list's - #1372
Merged
Merged
Conversation
Base automatically changed from
fix/licence-metadata-familiar-data
to
master
November 13, 2026 05:53
A compiler's list copied whole keeps its licence, and nam_dict's is the GFDL, which the core will not carry (decisions/shipped-data-licences, 2026-11-12 #1370 FACTS WE MEASURE). Its 736 familiar-form pairs leave before any release ships them, 563 of them not in the nicknames list; the familiar-form outcome reads English pairs alone until other languages' pairs are rebuilt from CC0 data and reviewed by hand. - tools/vocab/familiar.py writes the nicknames list alone - the vocabulary and its compiled copies lose nam_dict's readings; mt.toml and sq.toml, which held nothing else, go - LICENSE-nam_dict and README name the suggester's common given names alone; the GFDL stays in the metadata until those go too - tests, docs/matching.rst, customize.rst and the release log move to English examples; decisions/name-matching records the measure Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- plant a file of familiar readings alone to test _reading_index.tags()'s filter, whose last shipped witnesses were mt.toml and sq.toml - Maximilian / Maxwell for the never-chained example, Max / Maxim no longer being a shipped pair - name every part of the 2026-11-09 entry the drop supersedes, record that the 173 shared pairs skipped the list's review, and give the match_diff figures per setting as the tool printed them - docs/locales.rst, group-suggestion's Standing line, the licence entry's issue and Standing tense, and stale comments - AGENTS.md: a filter whose only witnesses are shipped files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derek73
force-pushed
the
feat/drop-nam-dict-familiar-forms
branch
from
November 13, 2026 06:04
d9971df to
7a5cd42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 736 familiar-form pairs copied from Jörg Michael's nam_dict (GFDL) before any release ships them, keeping the ODU nicknames list's English pairs. This carries out the rule recorded in #1370: a compiler's list copied whole keeps its licence, and the core will not carry the GFDL (decisions/shipped-data-licences, 2026-11-12 #1370 FACTS WE MEASURE).
Rebased onto master after #1370 merged.
What changes
tools/vocab/familiar.pywrites the nicknames list alone intoen.toml. The nam_dict reader, the per-country placement, the bands notes and the de-duplication against nam_dict are removed.mt.tomlandsq.tomlheld nothing else, so they are deleted, andhu.tomlnow holds exclusions only.FAMILIARgoes from 2,743 pairs of 2,665 names to 2,180 pairs of 2,015 names.familiar-formis English-only until other languages' familiar forms are rebuilt from pairs found in CC0 data and reviewed by hand. That rebuild is a separate follow-up PR.LICENSE-nam_dict's header and README's License bullet now name only_order_names.py's_COMMON_GIVENblock.GFDL-1.2-no-invariants-or-laterstays inlicense,license-filesand_THIRD_PARTY. Whichever merges second, this PR or the one replacing_COMMON_GIVENfrom ORCID, deletes the file and those three entries.docs/matching.rst,docs/customize.rst,docs/locales.rst, the vocab README and root AGENTS.md now use English examples. TheParser.matchingrelease bullet says the shipped pairs are English only.Measured
match_diff.py --base#1370's tip (848c00c), 31,212 pairs × 21 settings:familiar-form, and 919–929 under each of the four that do.familiar-form(Masha/Maria, Józsi/József). 924 given rows readconflictwhere they readfamiliar-form. Keys move on 3,532 rows.No parse moves, since no parse reads a familiar reading.
173 of nam_dict's pairs are also in the nicknames list, and they now ship as the list's readings. The list's review read only the 2,624 rows nam_dict didn't already hold. Both this change's reviewer and I read those 173 by hand and found none in a refused category.
Tests
sphinx-build -b doctestand the README doctest are clean.test_familiar_tool.pyis rewritten for the list alone. A new test checks that every shipped familiar reading is the list's and sits inen.toml.test_match.pyplants its Hungarian accent pairs in a caller's lexicon instead of relying on shipped pairs._reading_index.tags()'s filter for a file of familiar readings alone, whose last shipped examples weremt.tomlandsq.toml. Negative control: it fails with the filter removed.Reviews run
🤖 Generated with Claude Code