Repository navigation
build: remove @angular-devkit/schematics devDependency from tests - #34708
Closed
alan-agius4 wants to merge 1 commit into
Closed
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
Update file_system_engine_host_test_lib to depend directly on //packages/angular_devkit/schematics instead of linking the workspace package through tests/package.json.
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Bazel build dependencies for the file system engine host tests to reference the local '@angular-devkit/schematics' package directly from '//packages/angular_devkit/schematics' instead of referencing it via 'node_modules' in the tests directory. Consequently, the '@angular-devkit/schematics' dependency has been removed from 'tests/package.json'. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
tests/package.jsondeclares@angular-devkit/schematicsindevDependenciessolely so//tests/angular_devkit/schematics/tools/file-system-engine-host:file_system_engine_host_test_libcan reference//tests:node_modules/@angular-devkit/schematics.Issue Number: N/A
What is the new behavior?
@angular-devkit/schematicsis removed fromtests/package.json(andpnpm-lock.yaml), andfile_system_engine_host_test_libdepends directly on//packages/angular_devkit/schematics.Does this PR introduce a breaking change?
Other information