Repository navigation
Conversation
Collaborator
Author
|
@Barthelemy the code preserves the same functionality and for the most part, it was just moved from one place to another, so I don't think there is a need for a very thorough review of the logic, but just a check whether you agree with how the refactor is done. I validated (hopefully) all the functionalities by running TrendingTask with different customization options and inspecting the generated objects. |
knopers8
force-pushed
the
trending-lt
branch
from
November 11, 2026 13:12
9629fc2 to
c605235
Compare
To allow for reimplementation of TrendingTask as a late task, but keeping both for backwards-compatibility. As a bonus, we are able to test the trending functionalities much easier and wider. Needed for QC-1362.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow for reimplementation of TrendingTask as a late task, but keeping both for backwards-compatibility. As a bonus, we are able to test the trending functionalities much easier and wider.
Needed for QC-1362.
Assisted by Claude Sonnet 5.5