Skip to content

[PWGHF] Compute identified hadron v2 from charm-hadron tables - #18695

Merged
stefanopolitano merged 11 commits into
AliceO2Group:masterfrom
Marcellocosti:fix_correl
Nov 12, 2026
Merged

[PWGHF] Compute identified hadron v2 from charm-hadron tables#18695
stefanopolitano merged 11 commits into
AliceO2Group:masterfrom
Marcellocosti:fix_correl

Conversation

@Marcellocosti

@Marcellocosti Marcellocosti commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwghf PWG-HF label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 6 warnings, 🔕 0 disabled

@Marcellocosti
Marcellocosti marked this pull request as ready for review November 11, 2026 16:46
@alibuild alibuild mentioned this pull request Nov 11, 2026
Merged
@alibuild alibuild mentioned this pull request Nov 11, 2026
Merged
@alibuild

alibuild commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 378a28a at 2026-11-12 03:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 15 errors and 20 warnings.'
Found 15 errors and 20 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/0fe463de57ce6ad93f05993fc05f118f169f1242/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:37:1: error: included header TH1F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:38:1: error: included header TH2F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:39:1: error: included header TH3F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:194:73: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:194:100: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:194:127: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:198:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:242:40: error: no header providing "TH1F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:242:46: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:245:40: error: no header providing "TH2F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:248:40: error: no header providing "TH3F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:432:32: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:440:32: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:448:32: error: no header providing "TH3" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:462:21: error: no header providing "Int_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/0fe463de57ce6ad93f05993fc05f118f169f1242/O2Physics-code-check/warnings.txt
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:102:3: warning: function 'ptTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:103:3: warning: function 'ptAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:104:3: warning: function 'etaTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:105:3: warning: function 'etaAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:106:3: warning: function 'deltaEta' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:107:3: warning: function 'phiTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:108:3: warning: function 'phiAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:109:3: warning: function 'deltaPhi' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:110:3: warning: function 'nTpcCrossedRowsTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:111:3: warning: function 'itsClsMapTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:112:3: warning: function 'itsNClsTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:113:3: warning: function 'dcaXYTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:114:3: warning: function 'dcaZTrig' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:115:3: warning: function 'nTpcCrossedRowsAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:116:3: warning: function 'itsClsMapAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:117:3: warning: function 'itsNClsAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:118:3: warning: function 'dcaXYAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:119:3: warning: function 'dcaZAssoc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGHF/HFC/TableProducer/correlatorFlowCharmHadronsReduced.cxx:433:19: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
[0 more errors; see full log]

Full log here.

@alibuild alibuild mentioned this pull request Nov 12, 2026
Merged
@Marcellocosti
Merge pull request #101 from alibuild/alibot-cleanup-18695
aaeb3e7 
Please consider the following formatting changes to AliceO2Group#18695
@stefanopolitano
stefanopolitano merged commit b93cf23 into AliceO2Group:master Nov 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanopolitano stefanopolitano stefanopolitano approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marcellocosti @alibuild @stefanopolitano