Skip to content

[PWGCF] Net charge fluctuations Update3: Updated the Particle Identification in Code - #18676

Merged
fsii merged 30 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3
Nov 12, 2026
Merged

fsii merged 30 commits into
AliceO2Group:masterfrom
pravatp98:NetChargeFluctuations3

Conversation

@pravatp98

Copy link
Copy Markdown
Contributor

Updated for Particle Identification

Updated for  efficiency correction and sub-sampling
…ficiency correction

Refactor identification bits to use constexpr instead of #define, update includes to comment out unused headers, and improve readability of various functions.
Commented out unused identification bits for clarity.
Added configurable pT cutoffs for kaons and protons, and updated relevant sections to use these cutoffs for efficiency corrections.
@github-actions github-actions Bot added the pwgcf label Nov 10, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Net charge fluctuations3 [PWGCF] Net charge fluctuations3 Nov 10, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b440ab7 at 2026-11-10 07:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/c368c14bbbe7e543f50d16193113419d210df029/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:663:18: error: no header providing "o2::framework::LabeledArray" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d8d29eb at 2026-11-10 07:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/358bc08769a78bc87db145039338f485de76a146/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:663:18: error: no header providing "o2::framework::LabeledArray" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 32e84b7 at 2026-11-10 18:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:34:10: fatal error: Framework/LabeledArray.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 32e84b7 at 2026-11-10 19:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:34:10: fatal error: Framework/LabeledArray.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 32e84b7 at 2026-11-10 20:27:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/nchCumulantsId.cxx:34:10: fatal error: Framework/LabeledArray.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft November 10, 2026 20:22
@vkucera

vkucera commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

@pravatp98 You are supposed to test your changes locally before opening a PR, which you apparently did not do, since you are including a header that does not exist.

@vkucera

vkucera commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

@pravatp98 Please fix the PR title. It does not say anything about what you did. See the contribution guidelines. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#pull-requests

@pravatp98

Copy link
Copy Markdown
Contributor Author

@pravatp98 You are supposed to test your changes locally before opening a PR, which you apparently did not do, since you are including a header that does not exist.

thank you vit. thank you for poinitng this out, i will keep this in mind, Since the earlier issue was one header file missing i just kept it. i have fixed that as per your suggestion

@pravatp98 pravatp98 changed the title [PWGCF] Net charge fluctuations3 [PWGCF] Net charge fluctuations Update3: Updated the Particle Identification in Code Nov 11, 2026
@pravatp98
pravatp98 marked this pull request as ready for review November 12, 2026 13:46
@pravatp98

pravatp98 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-11-12 21-32-01 Dear @victor-gonzalez @SwatiSaha-1997 @dsarkaralice @isputows @fsii I have updated the code for the Analysis. As you can see it has passed all checks so kindly review and approve the PR With best Regards Pravat

@SwatiSaha-1997

Copy link
Copy Markdown
Collaborator

Dear @pravatp98, you should request Iwona and Fan for approval of EbyE PRs. They are in charge of this.
Thanks
Swati

@pravatp98

Copy link
Copy Markdown
Contributor Author

Dear @fsii @isputows
I have updated the code for the Analysis. As you can see it has passed all checks so kindly review and approve the PR
With best Regards Pravat

@fsii
fsii merged commit e4d60b1 into AliceO2Group:master Nov 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants