Repository navigation
Conversation
This passes a common distortion file to the TPC digitizer lanes, so that the scaled distortions are computed once per job. - Used for distortion type 2 when o2-sim-digitizer-workflow knows --tpc-distortion-file. - The file is tpc_scaled_distortions.root in the job directory. - Only one lane computes, so the lanes get NWORKERS_TF threads for the distortions. https://its.cern.ch/jira/browse/O2-7309 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For distortion type 2, the TPC digitizer lanes now share the scaled distortions through
tpc_scaled_distortions.rootin the job directory, so that they are computed once per job instead of once per lane and timeframe. Since only one lane computes, the lanes getNWORKERS_TFthreads for the computation.The option is only passed when
o2-sim-digitizer-workflowknows--tpc-distortion-file(AliceO2Group/AliceO2#16091), so nothing changes with older software. For a Pb-Pb timeframe this brings the TPC digitization from 216 s to 48 s and saves about 4 GiB of memory, with identical digits.Assisted by Claude Code.