Repository navigation
Avoid InheritsFrom in CCDB object extraction - #16115
Merged
Merged
Conversation
TClass::InheritsFrom("TObject") on an STL collection such as
std::vector<o2::detectors::AlignParam> makes cling instantiate the class and
read a large part of the ROOT module data. IsTObject() gives the same answer
without this. In o2-sim, which fetches the alignment this way, this saves about
150 MB (16 workers, peak PSS 6384 -> 6215 MB) with bit-identical hits.
sawenzel
requested review from
a team,
Barthelemy and
costing
as code owners
November 12, 2026 15:30
ktf
approved these changes
Nov 12, 2026
costing
approved these changes
Nov 12, 2026
costing
left a comment
costing
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Sandro, glad to hear that this saves so much memory!
Member
|
#16116 might help as well then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TClass::InheritsFrom("TObject") on an STL collection such as
std::vectoro2::detectors::AlignParam makes cling instantiate the class and
read a large part of the ROOT module data. IsTObject() gives the same answer
without this. In o2-sim, which fetches the alignment this way, this saves about
150 MB (16 workers, peak PSS 6384 -> 6215 MB) with bit-identical hits.