Repository navigation
Fix the inverted and the external primary transport selection in the Stack - #16092
Merged
sawenzel merged 1 commit intoNov 10, 2026
Merged
Conversation
…Stack This fixes two problems in the transport selection of primaries. - With transportPrimaryInvert, the lambda negated the std::function instead of its result, so every primary was held back. - After loading an external selection, the check tested the member instead of the loaded function, so a failed load was not detected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems in the transport selection of primaries in the Stack.
transportPrimaryInvert, the lambda returned!transportPrimary, which negates thestd::functionobject rather than its result, so every primary was held back.mTransportPrimaryinstead of the loaded function. The member starts as a lambda that returns false, so a failed load was never detected.Both were found in a review of #16084 but are independent of it.
Assisted by Claude Code.